Support passing API Signing Key from the memory #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
Hi, @lbajolet-hashicorp, you have recently helped us (@obabec) to merge an addition of |
|
@anurag5sh Could you help us merge this PR? |
durnik-ivo
force-pushed
the
api-key-raw
branch
2 times, most recently
from
c945daf to
9651233
Compare
durnik-ivo
force-pushed
the
api-key-raw
branch
from
1cb5b28 to
5d65e33
Compare
Contributor
|
@durnik-ivo could you run |
Contributor
Author
@anurag5sh, oh, I knew I forgot something! Thanks, hopefully fixed now! :) |
anurag5sh
approved these changes
Dec 12, 2025
Contributor
anurag5sh
left a comment
anurag5sh
left a comment
There was a problem hiding this comment.
Looks good to me! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would like to add the option to provide the OCI API Signing Key directly from the memory by adding a
keyattribute. This is already supported by the OCI Terraform provider and is useful when running Packer from CI/CD. Thekeyis not inteded to be checked into the source control, but rather dynamically fetched from a secrets manager system. Setting thekeyoverrideskey_fileconsistently with the documented behaviour of the OCI Terraform provider.Additionally, small refactor and improvements of the surrounding comments and error messages were done.